Skip to content

chore: rewrite an outdated comment #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

chore: rewrite an outdated comment #1484

merged 1 commit into from
Mar 19, 2025

Conversation

Golovanov399
Copy link
Contributor

This resolves INT-3660.

The comment is outdated since we deserialize stuff from the input stream differently in ZKVM.

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-7 [-0.6%]) 1,231 334,086 17,903,104 - - -
fibonacci_program (+31 [+1.2%]) 2,722 1,500,096 51,485,167 - - -
regex_program (+161 [+2.1%]) 7,991 4,140,164 167,389,450 - - -
ecrecover_program (-18 [-1.2%]) 1,442 295,291 15,598,160 - - -
pairing (-19 [-0.4%]) 4,715 1,711,640 92,620,923 - - -

Commit: cb0b36a

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit cb55052 into main Mar 19, 2025
9 checks passed
@jonathanpwang jonathanpwang deleted the chore/wrong-comment branch March 19, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants