Skip to content

docs: update specs on RISC-V execution environment #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2025
Merged

Conversation

jonathanpwang
Copy link
Contributor

@jonathanpwang jonathanpwang commented Mar 20, 2025

Updates specs on the RISC-V execution environment for user IO.

Update internal docs to explain soundness of hint buffer. This relies on an invariant of the memory bus which is stated in #1490.

Also found that our read_vec_with_len implementation uses a bit of unsafe Rust that does not quite match the documented safety assumptions (though in practice currently does not have any problems). This is around a hidden assumption that the allocator always allocates on a 4-byte boundary.

This comment has been minimized.

Copy link
Contributor

@Golovanov399 Golovanov399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good modulo nit comments

This comment has been minimized.

This comment has been minimized.

@jonathanpwang jonathanpwang changed the title fix: require HINT_STORE_RV32 to have 4-byte alignment & docs docs: update specs on RISC-V execution environment Mar 20, 2025

This comment has been minimized.

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (-2 [-0.2%]) 1,241 334,086 17,903,104 - - -
fibonacci_program 2,680 1,500,096 51,485,167 - - -
regex_program (-29 [-0.4%]) 7,729 4,140,229 167,420,929 - - -
ecrecover_program (-15 [-1.0%]) 1,415 295,285 15,597,969 - - -
pairing (+80 [+1.7%]) 4,769 1,711,640 92,620,923 - - -

Commit: bf83481

Benchmark Workflow

@jonathanpwang jonathanpwang merged commit f3461e8 into main Mar 20, 2025
17 checks passed
@jonathanpwang jonathanpwang deleted the INT-3501 branch March 20, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants