feat: improved logging#1826
Open
al-rosenthal wants to merge 3 commits intoopenwallet-foundation:mainfrom
Open
Conversation
Signed-off-by: Alfred Rosenthal <alfred.k.rosenthal@gmail.com>
…bjects Signed-off-by: Alfred Rosenthal <alfred.k.rosenthal@gmail.com>
🦋 Changeset detectedLatest commit: ed870c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1826 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 326 326
Lines 11280 11280
Branches 3032 3127 +95
=======================================
Hits 6679 6679
+ Misses 4572 4554 -18
- Partials 29 47 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MacDeluca
reviewed
Apr 29, 2026
Comment on lines
+49
to
+57
| if (value instanceof Error) { | ||
| return { | ||
| name: value.name, | ||
| message: value.message, | ||
| stack: value.stack?.split('\n').slice(1).map((line) => line.trim()) ?? [], | ||
| } | ||
| } | ||
| return value | ||
| } |
Contributor
There was a problem hiding this comment.
suggestion: can we include cause?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Instructions
n/a
Acceptance Criteria
Screenshots, videos, or gifs
n/a
Breaking change guide
n/a
Related Issues
n/a
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓