fix: issuer name showing as uuid#1834
Open
KjartanE wants to merge 3 commits intoopenwallet-foundation:mainfrom
Open
fix: issuer name showing as uuid#1834KjartanE wants to merge 3 commits intoopenwallet-foundation:mainfrom
KjartanE wants to merge 3 commits intoopenwallet-foundation:mainfrom
Conversation
Signed-off-by: Kjartan Einarsson <kjartanreinarsson@gmail.com>
Signed-off-by: Kjartan Einarsson <kjartanreinarsson@gmail.com>
🦋 Changeset detectedLatest commit: 4976307 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Kjartan Einarsson <kjartanreinarsson@gmail.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1834 +/- ##
==========================================
+ Coverage 59.50% 59.51% +0.01%
==========================================
Files 326 326
Lines 11293 11299 +6
Branches 3140 3136 -4
==========================================
+ Hits 6720 6725 +5
+ Misses 4543 4526 -17
- Partials 30 48 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Signed-off-by: Kjartan Einarsson kjartanreinarsson@gmail.com
Summary of Changes
Fixes the issuer name appearing as a raw connection UUID on the Credential Offer and Credential Details screens when the underlying connection has no
aliasortheirLabel.useCredentialConnectionLabelnow accepts an optionaloverlayargument and, when the connection has no alias/theirLabel, falls back tooverlay.metaOverlay.issuerbefore falling back to'Unknown Contact'. The rawconnectionIdUUID is no longer returned as a label.CredentialOfferandCredentialDetailsscreens updated to pass the resolved overlay into the hook so the issuer name from branding metadata is used.Testing Instructions
alias/theirLabelset, but a branding/meta overlay with anissuervalue is available.aliasortheirLabel, that value should still be shown unchanged.Unknown Contact.Acceptance Criteria
Unknown Contact(no connection) or empty string.Screenshots, videos, or gifs
N/A
Breaking change guide
N/A —
useCredentialConnectionLabel's newoverlayparameter is optional, so existing callers continue to work without changes.Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓