Skip to content

fix: issuer name showing as uuid#1834

Open
KjartanE wants to merge 3 commits intoopenwallet-foundation:mainfrom
KjartanE:fix/issuer_name
Open

fix: issuer name showing as uuid#1834
KjartanE wants to merge 3 commits intoopenwallet-foundation:mainfrom
KjartanE:fix/issuer_name

Conversation

@KjartanE
Copy link
Copy Markdown
Contributor

@KjartanE KjartanE commented May 7, 2026

Signed-off-by: Kjartan Einarsson kjartanreinarsson@gmail.com

Summary of Changes

Fixes the issuer name appearing as a raw connection UUID on the Credential Offer and Credential Details screens when the underlying connection has no alias or theirLabel.

  • useCredentialConnectionLabel now accepts an optional overlay argument and, when the connection has no alias/theirLabel, falls back to overlay.metaOverlay.issuer before falling back to 'Unknown Contact'. The raw connectionId UUID is no longer returned as a label.
  • CredentialOffer and CredentialDetails screens updated to pass the resolved overlay into the hook so the issuer name from branding metadata is used.

Testing Instructions

  1. Receive a credential offer from an issuer where the underlying connection has no alias / theirLabel set, but a branding/meta overlay with an issuer value is available.
  2. Open the Credential Offer screen — the issuer name from the overlay should be displayed (not a UUID).
  3. Accept the credential and open the Credential Details screen — the issuer name should also be displayed there.
  4. Regression check: for credentials whose connection does have an alias or theirLabel, that value should still be shown unchanged.
  5. Regression check: for credentials with no connection at all, the label should still fall back to Unknown Contact.

Acceptance Criteria

  • Credential Offer and Credential Details screens never display a raw connection UUID as the issuer/contact label.
  • When connection alias / theirLabel exist, they continue to take precedence over the overlay issuer.
  • When neither alias/theirLabel nor an overlay issuer is available, the label falls back to Unknown Contact (no connection) or empty string.

Screenshots, videos, or gifs

N/A

Breaking change guide

N/A — useCredentialConnectionLabel's new overlay parameter is optional, so existing callers continue to work without changes.

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • If applicable, added changeset(s)
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

KjartanE added 2 commits May 7, 2026 12:28
Signed-off-by: Kjartan Einarsson <kjartanreinarsson@gmail.com>
Signed-off-by: Kjartan Einarsson <kjartanreinarsson@gmail.com>
@KjartanE KjartanE requested a review from a team as a code owner May 7, 2026 19:33
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

🦋 Changeset detected

Latest commit: 4976307

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@bifold/core Major
@bifold/remote-logs Major
@bifold/oca Major
@bifold/react-hooks Major
@bifold/react-native-attestation Major
@bifold/verifier Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Kjartan Einarsson <kjartanreinarsson@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.51%. Comparing base (a6e2eb6) to head (4976307).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/screens/CredentialOffer.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
+ Coverage   59.50%   59.51%   +0.01%     
==========================================
  Files         326      326              
  Lines       11293    11299       +6     
  Branches     3140     3136       -4     
==========================================
+ Hits         6720     6725       +5     
+ Misses       4543     4526      -17     
- Partials       30       48      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jleach jleach self-assigned this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants