luci-mod-status: add description to port status#8659
Open
YusDyr wants to merge 1 commit into
Open
Conversation
YusDyr
added a commit
to YusDyr/luci
that referenced
this pull request
May 25, 2026
If a `config device` section in `/etc/config/network` has an `option description` set for a physical port (e.g. lan2, lan3), the description is shown as a subtitle below the port name in the Port Status widget on the Overview page. Ports without a description are unaffected. Signed-off-by: Denis Iusupov <yusdyr@gmail.com>
2237982 to
3fcec19
Compare
efahl
reviewed
May 27, 2026
| ]; | ||
|
|
||
| if (portDesc) | ||
| ifaceboxChildren.push(E('div', { 'class': 'ifacebox-head', 'style': 'font-weight:normal;font-size:80%;overflow:hidden;white-space:nowrap;text-overflow:ellipsis', 'title': portDesc }, portDesc)); |
Contributor
There was a problem hiding this comment.
How do these hard-coded style elements look in the other supported themes? Seems like maybe a new class is needed, or pick from an existing one that's "close enough"?
(You only show one graphic in the PR, so it's hard to know how it will look with all of default, 2020 and material.)
openwrt-ai
reviewed
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion change to #8657 (which adds
option descriptionsupport tothe Interfaces and Devices views in
luci-mod-network).If a
config devicesection in/etc/config/networkhas anoption descriptionset for a physical port (e.g.lan2,lan3),the description is shown as a subtitle below the port name in the
Port Status widget on the Overview page.
…; the full text is shown as a tooltip on hoverUse case
Label physical LAN ports on DSA-based routers so the port function is
visible at a glance on the Overview page (e.g.
lan2→NVR/Cameras,lan3→TV).Screenshots
Port Status widget — description subtitle under port name:
Testing
option descriptionset: subtitle appears below port nameoption description: no subtitle, layout unchanged…, full text on hoverTested on
OpenWrt version: OpenWrt 24.10.3
LuCI version: openwrt-24.10
Web browser: Safari