Skip to content

luci-mod-status: fix crashing on IPv4 special routes#8676

Open
BadAimWeeb wants to merge 1 commit into
openwrt:masterfrom
BadAimWeeb:feat-ipv4-special-routes
Open

luci-mod-status: fix crashing on IPv4 special routes#8676
BadAimWeeb wants to merge 1 commit into
openwrt:masterfrom
BadAimWeeb:feat-ipv4-special-routes

Conversation

@BadAimWeeb

Copy link
Copy Markdown

Pull request details

Description

In IPv4, if you're configuring a route as unreachable, there will be no next hop or device that is included in line, making old regex failed.

IPv6 works normally before this change, as busybox will include some more stuff after route.

An example for parsing would be unreachable 172.16.0.0/12.


Tested on

OpenWrt version: OpenWrt 25.12.4 (r32933-4ccb782af7)
LuCI version: 26.133.20346~e9ebca7
Web browser(s): LibreWolf 151.0.2-1


Checklist

  • This PR is not from my main or master branch 💩, but a separate branch. ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff).
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages.
  • Incremented 🆙 any PKG_VERSION in the Makefile.
  • (Optional) Includes what Issue it closes (e.g. openwrt/luci#issue-number).
  • (Optional) Includes what it depends on (e.g. openwrt/packages#pr-number in sister repo).

@BadAimWeeb BadAimWeeb changed the title luci-mod-status: add support for IPv4 special routes luci-mod-status: fix crashing on IPv4 special routes Jun 3, 2026
@github-actions

This comment has been minimized.

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.


Generated by Claude Code

In IPv4, if you're configuring a route as unreachable, there will be no next hop
or device that is included in line, making old regex failed.

IPv6 works normally before this change, as busybox will include some more stuff
after route.

Signed-off-by: Lê Quang Lâm <badaimweeb@protonmail.com>
@BadAimWeeb BadAimWeeb force-pushed the feat-ipv4-special-routes branch from 10c9f54 to 1b7ca99 Compare June 4, 2026 11:35

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants