luci-{base,mod-system}: add support for RGB LEDs#8678
Conversation
add color channel attributes to getLEDs ubus call Signed-off-by: Tomáš Macholda <tomas.macholda@nic.cz>
4d56f36 to
3db14aa
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 2 new commits; the RGB-LED changes wire up cleanly against the in-tree backend — the new brightness and color_<channel> UCI options are read by package/base-files/files/etc/init.d/led (config_get ... color_${color} and config_get brightness), so this is not a frontend-only addition. access() on the rpcd side follows the existing existence-check pattern in the same file. One style nit inline.
Generated by Claude Code
added support for setting LED brightness and colours channels and max_brightness are pulled dynamically from sysfs Signed-off-by: Tomáš Macholda <tomas.macholda@nic.cz>
3db14aa to
509a354
Compare
|
related to (but not dependent on) openwrt/openwrt#23670 |
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit; no new issues found. The delta since the last review is the requested style fix (var→let/const and the missing trailing semicolons), which resolves the earlier nit.
Generated by Claude Code
Pull request details
Description
Add support for changing LED brightness and colors in LuCI.
The attributes (color names, maximum and current brightness, etc.) are pulled directly from sysfs (in case of using e.g. CMY instead of RGB) which might hamper translation efforts. It may be worth it to simply hard-code the color names to be RGB for this purpose.
Note: I have written very little JS code overall so there are definitely stupid mistakes in the code.
Screenshot or video of changes (if applicable)
Maintainer (preferred)
@feckert
Tested on
OpenWrt version: openwrt 24.10 (r29199+104-d5ac5cdfb2)
LuCI version: LuCI openwrt-24.10 branch (24.297.79519~bcd13b9)
Web browser(s): Firefox 151.0.2-1
Checklist
Signed-off-by: <my@email.address>row (viagit commit --signoff).<package name>: titlefirst line subject for packages.PKG_VERSIONin the Makefile.