luci-app-usteer: Fix formatting of band_steering_signal_threshold option#8719
Open
KittDoesntCode wants to merge 1 commit into
Open
luci-app-usteer: Fix formatting of band_steering_signal_threshold option#8719KittDoesntCode wants to merge 1 commit into
KittDoesntCode wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
KittDoesntCode
force-pushed
the
band_steering_signal_threshold-fix
branch
2 times, most recently
from
c0d4385 to
f46c258
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Remove the extra space after 'band_steering_signal_threshold' so that the variable/option is recognized and address a uci/set error when trying to use it. Signed-off-by: Kitt Diebold <kitt@kittdiebold.com>
KittDoesntCode
force-pushed
the
band_steering_signal_threshold-fix
branch
from
f46c258 to
160c177
Compare
openwrt-ai
reviewed
Jun 19, 2026
Contributor
|
good catch! Note that soon this construct can actually be removed, provided that somebody updates the makefile of usteer file such that the latest commits actually get build into the usteer package, but until then this should fix that bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
Description
There is an extra space after band_steering_signal_threshold, keeping luci from reading the option in the configuration file and causing a uci/set error when trying to change it when using luci.
Screenshot or video of changes (if applicable)
n/a
Maintainer (preferred)
@Ramon00 (Ramon Van Gorkom Ramon00c00@gmail.com)
Tested on
OpenWrt version: OpenWrt 25.12.4 (r32933-4ccb782af7)
LuCI version: LuCI (HEAD detached at e9ebca7) branch (26.133.20346~e9ebca7)
Web browser(s): Chrome 149.0.7827.114
Checklist
Signed-off-by: <my@email.address>row (viagit commit --signoff).<package name>: titlefirst line subject for packages.PKG_VERSIONin the Makefile.