Skip to content

Should we do optimistic locking in KubernetesDependentResource when event recording is on? #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue Aug 8, 2023 · 1 comment
Assignees

Comments

@csviri
Copy link
Collaborator

csviri commented Aug 8, 2023

EventRecording is a quite complex feature, that might be simplified in close future. See:
#2005

Currently we do optimistic locking when updating the resources, before we did event recording this was necessary for the simplified appraoch (just putting the resource into temp. cache), need check if this is still necessary with event recording in cases.

The output of this issue should be also an ADR, that will explain the whole concept, workflows, etc.

@csviri csviri self-assigned this Aug 8, 2023
@csviri
Copy link
Collaborator Author

csviri commented Aug 14, 2023

at the end we decided to replace the recording mechanism with in this PR: #2012

Thus, this is issue does not apply anymore, will close it.

@csviri csviri closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant