Skip to content

fix: misleading warning message on workflow execution #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,20 @@ public AbstractWorkflowExecutor(Workflow<P> workflow, P primary, Context<P> cont
protected abstract Logger logger();

protected synchronized void waitForScheduledExecutionsToRun() {
// in case when workflow just contains non-activated dependents,
// it needs to be checked first if there are already no executions
// scheduled at the beginning.
if (noMoreExecutionsScheduled()) {
return;
}
while (true) {
try {
// in case when workflow just contains non-activated dependents,
// it needs to be checked first if there are already no executions
// scheduled at the beginning.
this.wait();
if (noMoreExecutionsScheduled()) {
break;
} else {
logger().warn("Notified but still resources under execution. This should not happen.");
}
this.wait();
} catch (InterruptedException e) {
if (noMoreExecutionsScheduled()) {
logger().debug("interrupted, no more executions for: {}", primaryID);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class DependentOperationEventFilterIT {
@RegisterExtension
LocallyRunOperatorExtension operator =
LocallyRunOperatorExtension.builder()
.withNamespaceDeleteTimeout(2)
.withReconciler(new DependentOperationEventFilterCustomResourceTestReconciler())
.build();

Expand Down