feat: initial support for dependent resources #726
Conversation
metacosm
force-pushed
the
dependent-resources-ng
branch
from
395ddb1 to
d8013e8
Compare
|
|
||
| public DefaultContext(RetryInfo retryInfo) { | ||
| public DefaultContext(RetryInfo retryInfo, Controller<P> controller, P primaryResource) { |
There was a problem hiding this comment.
Should this go to primary context? Cannot be an implementation of Reconciler that prodives these?
To have the current default APIs unchanged? Wouldn't that be possible?
metacosm
force-pushed
the
dependent-resources-ng
branch
from
401ada2 to
3e479bd
Compare
metacosm
changed the title
| } | ||
|
|
||
| @Override | ||
| public <T extends HasMetadata> T getSecondaryResource(Class<T> expectedType, |
There was a problem hiding this comment.
What is difference between dependent and secondary resource?
There was a problem hiding this comment.
They're the same. I should probably pick one and stick to it 😄
Based on the question during the last operator sdk call, I think I will go with secondary resources.
| @@ -12,6 +13,6 @@ | |||
| * @param eventSourceRegistry the {@link EventSourceRegistry} where event sources can be | |||
| * registered. | |||
| */ | |||
| void prepareEventSources(EventSourceRegistry<T> eventSourceRegistry); | |||
| void prepareEventSources(EventSourceRegistry<T> eventSourceRegistry, Cloner cloner); | |||
There was a problem hiding this comment.
Why is the cloner needed here? Is not generic for the whole operator?
| import io.javaoperatorsdk.operator.processing.event.source.ResourceCache; | ||
| import io.javaoperatorsdk.operator.processing.event.source.ResourceEventSource; | ||
|
|
||
| public class DependentResource<R extends HasMetadata, P extends HasMetadata> { |
There was a problem hiding this comment.
P is the parent? Or what it is used for?
| count.getAndIncrement(); | ||
| Thread.sleep(waitTime); | ||
| } catch (InterruptedException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Should be a log message, or even fail probably
metacosm
force-pushed
the
dependent-resources-ng
branch
4 times, most recently
from
81aeed6 to
e67efac
Compare
metacosm
force-pushed
the
dependent-resources-ng
branch
from
9e1e314 to
591c97f
Compare
|
Closing this in favor of #785 |
This PR provides annotation-based configuration of dependent resources, which the controller then automatically handles, taking care of propagating creation/update of said dependent resources depending on how they are configured. The functional scope is still pretty limited and more changes will be needed but this sets up the architecture for more changes.
In particular, handling of readiness / status reporting of dependent resources will also be tackled at some point.