Refactor for cli and pkg/action decoupling and deduplication#23
Merged
joelanford merged 8 commits intooperator-framework:mainfrom Nov 11, 2020
Merged
Refactor for cli and pkg/action decoupling and deduplication#23joelanford merged 8 commits intooperator-framework:mainfrom
joelanford merged 8 commits intooperator-framework:mainfrom
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
joelanford
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Member
varshaprasad96
left a comment
varshaprasad96
left a comment
There was a problem hiding this comment.
Tested this PR. Everything works well, except for the issue while uninstalling the operator. However, this refactor doesn't seem to be the problem as it occurs in master too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.