Skip to content

Support label selector for sdk.Watch #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gkumar7 opened this issue Jun 14, 2018 · 4 comments
Closed

Support label selector for sdk.Watch #314

gkumar7 opened this issue Jun 14, 2018 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@gkumar7
Copy link

gkumar7 commented Jun 14, 2018 •
edited
Loading

sdk.Watch should also support passing in a set of a labels to further filter the crds being monitored. There seems to be a todo listed in pkg/sdk/api.go for this:
TODO: support opts for specifying label selector.

Has there been any progress for this?
@rithujohn191 rithujohn191 added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 14, 2018
@rithujohn191
Copy link
Contributor

@gkumar7 thank you for opening an issue. This feature is definitely useful and has been on our radar. We have not yet begun working on it. We will update this issue when we do.

@CSdread
Copy link
Contributor

CSdread commented Aug 22, 2018 •
edited
Loading

@hasbro17

screen shot 2018-08-22 at 1 16 48 pm

lets continue here as this seems to be the right issue. Now that we have support for the functional argument pattern i think we can just add it as a functional argument and then add the labels into the watch functions. Once #418 is merged I will code up a PR.

@CSdread
Copy link
Contributor

CSdread commented Aug 25, 2018

#428

@CSdread
Copy link
Contributor

CSdread commented Aug 28, 2018

This is done with the above mentioned PR and can be closed @theishshah

@squeed squeed mentioned this issue Aug 9, 2019
Closed
m1kola pushed a commit to m1kola/operator-sdk that referenced this issue Jun 7, 2024
@openshift-merge-robot
Merge pull request operator-framework#314 from oceanc80/bump-versions
8c2ffdf 
OCPBUGS-11513: Bump OCP to 4.13 and UBI to 8.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rithujohn191 @gkumar7 @theishshah @CSdread