Graceful shutdown timeout #4571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliot Fehr <[email protected]>
Signed-off-by: Elliot Fehr <[email protected]>
elliotfehr
force-pushed
the
graceful-shutdown-timeout
branch
from
6a765eb to
33181cf
Compare
Signed-off-by: Elliot Fehr <[email protected]>
elliotfehr
force-pushed
the
graceful-shutdown-timeout
branch
from
de728cd to
d7de15c
Compare
estroz
suggested changes
Feb 24, 2021
There was a problem hiding this comment.
In general I'm ok with allowing flag overrides of operator values. I will say, now that controller-runtime supports a config, flags should be added in controller-runtime using component-base's cli/flag lib to get these flags for free. I'm ok adding a one-off flag like this now as long as the name aligns with what would be added in controller-runtime so config flags can be switched in later without a breaking change.
| @@ -0,0 +1,5 @@ | |||
| entries: | |||
| - description: > | |||
| For Ansible-based operators, allow passing a --drain-time to configure the duration the manager should wait before stopping. | |||
There was a problem hiding this comment.
Why call this --drain-time? Does this terminology come from somewhere?
There was a problem hiding this comment.
No real reason or preference here. Any suggestions for what to name it?
There was a problem hiding this comment.
Updated all references!
Signed-off-by: Elliot Fehr <[email protected]>
Signed-off-by: Elliot Fehr <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 28, 2021
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 28, 2021
Signed-off-by: reinvantveer <[email protected]>
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 28, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adds a
--drain-timeto ansible based operatorsMotivation for the change:
This is configurable in the manager but not possible to override using environment variables or CLI flags for roles that might take more than the 30 second default to complete.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs