Skip to content

pkg/ansible,pkg/scaffold/ansible; enables leader election for ansible operators #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 18, 2019
Merged

pkg/ansible,pkg/scaffold/ansible; enables leader election for ansible operators #904

merged 5 commits into from
Jan 18, 2019

Conversation

mhrivnak
Copy link
Member

Leader election has been enabled for a while for go-based operators. This uses the same approach and very similar code.

@mhrivnak mhrivnak added kind/feature Categorizes issue or PR as related to a new feature. language/ansible Issue is related to an Ansible operator project labels Jan 11, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2019
hasbro17
hasbro17 reviewed Jan 11, 2019
View reviewed changes
@mhrivnak mhrivnak force-pushed the leader-election-ansible branch from 3586924 to b05c0cb Compare January 11, 2019 20:59
hasbro17
hasbro17 approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhrivnak mhrivnak added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2019
@mhrivnak
Copy link
Member Author

Based on #920, I need to remove the readiness parts of this PR.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2019
@mhrivnak mhrivnak force-pushed the leader-election-ansible branch from b05c0cb to 14a56f2 Compare January 16, 2019 12:59
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2019
@mhrivnak mhrivnak removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2019
@mhrivnak
Copy link
Member Author

I removed the readiness probe, so this is good to go.

shawn-hurley
shawn-hurley requested changes Jan 16, 2019
View reviewed changes
Copy link
Member

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worried that this is actually on always and not on by default. I don't see a way to turn of the lock is that correct?

@mhrivnak
Copy link
Member Author

Worried that this is actually on always and not on by default. I don't see a way to turn of the lock is that correct?

Correct. That is also currently the case for go-based operators. We don't have a way to turn it off at runtime. It would be a reasonable thing to add as a command line arg or similar, but that goes back to the discussion we're having on #889 about how to change runtime settings.

@mhrivnak mhrivnak force-pushed the leader-election-ansible branch from 14a56f2 to 1fc0b47 Compare January 16, 2019 16:28
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2019
@mhrivnak mhrivnak force-pushed the leader-election-ansible branch from 1fc0b47 to d43cc4f Compare January 16, 2019 20:03
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2019
@mhrivnak
Merge pull request #1 from fabianvf/leader-election-ansible
2478c2e 
Fix test-cluster and add some debug statements
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2019
@mhrivnak mhrivnak merged commit b9401ae into operator-framework:master Jan 18, 2019
@mhrivnak mhrivnak deleted the leader-election-ansible branch January 18, 2019 17:59
shawn-hurley pushed a commit to shawn-hurley/operator-sdk that referenced this pull request Apr 23, 2019
@mhrivnak
pkg/ansible,pkg/scaffold/ansible; enables leader election for ansible…
66a3e17 
… operators (operator-framework#904)

* pkg/ansible,pkg/scaffold/ansible; enables leader election for ansible operators

* Fix test-cluster and add some debug statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-hurley shawn-hurley shawn-hurley approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/ansible Issue is related to an Ansible operator project size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhrivnak @shawn-hurley @hasbro17 @openshift-ci-robot @fabianvf