This repository was archived by the owner on Aug 12, 2024. It is now read-only.
Add ConfigMapSyncer controller and rukpak-ca configmap#483
Closed
joelanford wants to merge 1 commit intooperator-framework:mainfrom
Closed
Add ConfigMapSyncer controller and rukpak-ca configmap#483joelanford wants to merge 1 commit intooperator-framework:mainfrom
joelanford wants to merge 1 commit intooperator-framework:mainfrom
Conversation
a07b0a7 to
9e016be
Compare
af4a480 to
0a8ea0e
Compare
Member
Author
|
/hold cancel |
Member
Author
|
The controller-runtime multi-namespace cache builder PR has not merged yet, so I've refactored this PR to:
|
e4b633a to
fd8a0d9
Compare
13c8cbc to
1e91478
Compare
The ConfigMapSyncer syncs secret data to configmaps based on injection annotations present in configmaps in watched namespaces. We include a rukpak-ca configmap with these annotations present so that cluster administrators can share rukpak-ca trust without exposing the CA key that's present in the rukpak-ca secret. This commit also updates the rukpakctl binary to use the configmap rather than the secret to load the rukpak CA. This is helpful for rukpak users that might have access to read configmaps but not secrets in the rukpak system namespace. Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Member
Author
|
This PR is two steps forward, but one step back:
Therefore
|
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ConfigMapSyncer syncs secret data to configmaps based on injection
annotations present in configmaps in watched namespaces.
We include a rukpak-ca configmap with these annotations present so
that cluster administrators can share rukpak-ca trust without
exposing the CA key that's present in the rukpak-ca secret.
Closes #475
Signed-off-by: Joe Lanford joe.lanford@gmail.com