Nested reserialization issue

[ahmed-rashad-alnaggar]

Hi, thank you for this awesome package

I have a weird issue:

use Filament\Actions\Action;
use Filament\Notifications\Notification;
use Opis\Closure\Serializer;

$serialized = Serializer::serialize(Notification::make()
        ->title(static fn (): string => 'title' /*for example*/)
        ->danger()
        ->actions(fn () => [
            Action::make('monitor_logs')
                ->label(static fn (): string => 'label' /*for example*/)
                ->color('info')
                ->button()
                ->action(fn () => 1 /*for example*/)
        ]));

$unserialized =  Serializer::unserialize($serialized);

In the above code when the notification is unserialized everything works fine except for the notification's Action's action fn() => 1 it becomes the closure of the notification's actions' function fn() => [...] although the notification's Action's label is returned as expected?

[sorinsarca]

@ahmed-rashad-alnaggar what version of opis/closure are you using? Also, what version of PHP are you using?

[ahmed-rashad-alnaggar]

@ahmed-rashad-alnaggar what version of opis/closure are you using? Also, what version of PHP are you using?

opis/closure v4.4.0
PHP v8.3

[ahmed-rashad-alnaggar]

update:

actually I found another weird behavior while testing

if you tried to re-serialize the internal property value it will give you the serialized value of the fn() => [...]

$serialized = Serializer::serialize(Notification::make()
        ->title(static fn (): string => 'title' /*for example*/)
        ->danger()
        ->actions(fn () => [
            Action::make('monitor_logs')
                ->label(static fn (): string => 'label' /*for example*/)
                ->color('info')
                ->button()
                ->action(fn () => 1 /*for example*/)
        ]));

/** @var \Filament\Notifications\Notification */
$unserialized =  Serializer::unserialize($serialized);

$notificationActions = $unserialized->actions; // after changing it in the internal package to be public property
$serializednotificationActions =  Serializer::serialize($notificationActions);

$actionFunc = $unserialized->getActions()[0]->getActionFunction();
$serializedActionFunc =  Serializer::serialize($actionFunc);

The $serializednotificationActions and $serializedActionFunc are equal strings, the same behavior for the internal $lable property of the Action.

This behavior is different if you tried to serialize them from a fresh instance not an unserialized one, the output is the expected one.

[ahmed-rashad-alnaggar]

Hi @sorinsarca,

After more digging and debugging I found where the issue happens: when trying to execute a re-unserialized closure.

steps:

use Filament\Actions\Action;
use Filament\Notifications\Notification;
use Opis\Closure\Serializer;

// 1- serialize the notification
$serializedNotification = Serializer::serialize(Notification::make()
        ->title(static fn (): string => 'title' /*for example*/)
        ->danger()
        ->actions(fn () => [
            Action::make('monitor_logs')
                ->label(static fn (): string => 'label' /*for example*/)
                ->color('info')
                ->button()
                ->action(fn () => 1 /*for example*/)
        ]));

// 2- unserialize it
$unserializedNotification = Serializer::unserialize($serializedNotification);

// 3- serialize one of the unserialized notification properties
$serializedAction =  Serializer::serialize($unserializedNotification->getActions[0]);

// 4- unserialize it
$serializedAction =  Serializer::unserialize($serializedAction);

// BOOM the issue appears hear:
$serializedAction->getActionFunction()(); // returns the first serialized closure in the notification actions: 
// [
//            Action::make('monitor_logs')
//                ->label(static fn (): string => 'label' /*for example*/)
//                ->color('info')
//                ->button()
//                ->action(fn () => 1 /*for example*/)
// ]

I know it is weird to have this steps in a code, but I had a case where I needed to do this.

[ahmed-rashad-alnaggar]

I think it is relevant to caching.

[sorinsarca]

@ahmed-rashad-alnaggar I pushed some changed to master, can you test if this solves the issue?

Commit: 7d291c6

[ahmed-rashad-alnaggar]

Solved!

Thank you very much!

[sorinsarca]

v4.5.0 was just released