Fix #1954 : Optimise profile chooser fragment #1997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peculiaruc
changed the title
|
@rt4914 PTAL |
rt4914
suggested changes
Oct 13, 2020
|
@peculiaruc Also, please mark the checklist in PR description. You can do that by placing |
|
Will correct those thanks
…On Tue, 13 Oct 2020, 7:54 AM Rajat Talesra, ***@***.***> wrote:
Assigned #1997 <#1997> to
@peculiaruc <https://github.com/peculiaruc>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1997 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIOVAV2DXJYKFK363Z3IORDSKP2RZANCNFSM4SM6AA7Q>
.
|
|
@rt4914 PTAL |
|
Done @rajat Talesra <[email protected]> , PTAL
On Tue, 13 Oct 2020 at 08:51, Peculiar Umeh <[email protected]>
wrote:
… Will correct those thanks
On Tue, 13 Oct 2020, 7:54 AM Rajat Talesra, ***@***.***>
wrote:
> Assigned #1997 <#1997> to
> @peculiaruc <https://github.com/peculiaruc>.
>
> —
> You are receiving this because you were assigned.
> Reply to this email directly, view it on GitHub
> <#1997 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AIOVAV2DXJYKFK363Z3IORDSKP2RZANCNFSM4SM6AA7Q>
> .
>
|
Austinepass
pushed a commit
to Austinepass/oppia-android
that referenced
this pull request
Oct 15, 2020
* Optimise code in profile_chooser_fragment xml
* {{Fixes oppia#1954: Optimise code in profile chooser fragment xml}}
* {{Fixes oppia#1997:Optimise code in profile chooser fragment xml}}
Co-authored-by: pecpaker <[email protected]>
Austinepass
pushed a commit
to Austinepass/oppia-android
that referenced
this pull request
Oct 15, 2020
* Optimise code in profile_chooser_fragment xml
* {{Fixes oppia#1954: Optimise code in profile chooser fragment xml}}
* {{Fixes oppia#1997:Optimise code in profile chooser fragment xml}}
Co-authored-by: pecpaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
"Fixes #1954:" Optimized profile chooser fragment.xml by adding style to TextViews.'
Checklist