Skip to content

Fix #1892: Format FractionInputIsEquivalentToRuleClassifier #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 29, 2020
Merged

Fix #1892: Format FractionInputIsEquivalentToRuleClassifier #2024

merged 23 commits into from
Oct 29, 2020

Conversation

peculiaruc
Copy link
Contributor

@peculiaruc peculiaruc commented Oct 19, 2020 •
edited
Loading

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@peculiaruc peculiaruc changed the title {{Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}} Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier Oct 19, 2020
@peculiaruc peculiaruc changed the title Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier {{Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}} Oct 19, 2020
@peculiaruc peculiaruc changed the title {{Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier}} Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier Oct 20, 2020
pecpaker added 9 commits October 20, 2020 01:23
@peculiaruc
Copy link
Contributor Author

@rt4914 PTAL

@rt4914 rt4914 self-requested a review October 22, 2020 15:23
@rt4914 rt4914 self-assigned this Oct 22, 2020
@peculiaruc
Copy link
Contributor Author

@rt4914

@peculiaruc peculiaruc changed the title Fix #1892: Thoroughly test FractionInputIsEquivalentToRuleClassifier Fix #1892: Fornat FractionInputIsEquivalentToRuleClassifier Oct 25, 2020
@peculiaruc peculiaruc changed the title Fix #1892: Fornat FractionInputIsEquivalentToRuleClassifier Fix #1892: Format FractionInputIsEquivalentToRuleClassifier Oct 25, 2020
rt4914
rt4914 suggested changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested few changes.

Also, can you post a screenshot showing that tests are passing locally for you.

Thanks @peculiaruc

@rt4914 rt4914 assigned peculiaruc and unassigned rt4914 Oct 27, 2020
@peculiaruc
Copy link
Contributor Author

Screenshot from 2020-10-27 21-34-10

@peculiaruc
Copy link
Contributor Author

@rt4914 PTAL

@peculiaruc
Copy link
Contributor Author

@rt4914 PTAL

@anandwana001
Copy link
Contributor

Adding @Sarthak2601, as he is the issue author and needs to check if in a bit more detail.

@peculiaruc
Copy link
Contributor Author

@rt4914 PTAL

rt4914
rt4914 suggested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peculiaruc Suggested some typo related changes.

@peculiaruc
Copy link
Contributor Author

@rt4914 PTAL

rt4914
rt4914 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914
Copy link
Contributor

rt4914 commented Oct 29, 2020

@peculiaruc Please reply to all the comments that I have made, unless and until we do not resolve all the comments we cannot merge a PR.

@peculiaruc
Copy link
Contributor Author

I have suggested few changes.

Also, can you post a screenshot showing that tests are passing locally for you.

Thanks @peculiaruc

Noted. Done

@peculiaruc
Copy link
Contributor Author

@peculiaruc Please reply to all the comments that I have made, unless and until we do not resolve all the comments we cannot merge a PR.

Noted, Done

@peculiaruc
Copy link
Contributor Author

Adding @Sarthak2601, as he is the issue author and needs to check if in a bit more detail.

Noted

anandwana001
anandwana001 suggested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the TODO from its provider file.

anandwana001
anandwana001 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @peculiaruc

@rt4914 rt4914 merged commit ec2524c into oppia:develop Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@rt4914 rt4914 rt4914 approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@peculiaruc peculiaruc

@Sarthak2601 Sarthak2601

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thoroughly test FractionInputIsEquivalentToRuleClassifier
4 participants
@peculiaruc @anandwana001 @rt4914 @Sarthak2601