[FSSDK-9632] feat: Implement notification consistency across agent nodes#399
Merged
pulak-opti merged 36 commits intomasterfrom Nov 15, 2023
Merged
[FSSDK-9632] feat: Implement notification consistency across agent nodes#399pulak-opti merged 36 commits intomasterfrom
pulak-opti merged 36 commits intomasterfrom
Conversation
mikechu-optimizely
approved these changes
Sep 15, 2023
Contributor
mikechu-optimizely
left a comment
mikechu-optimizely
left a comment
There was a problem hiding this comment.
Transparently: I do not completely understand the implementation details, but I trust your tests cover the functional additions. LGTM
jaeopt
requested changes
Sep 27, 2023
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks great!
A couple of changes suggested. I will review again after discussion.
pulak-opti
force-pushed
the
pulak/fix-k8s-notifications
branch
from
a1b5849 to
ce403f7
Compare
jaeopt
requested changes
Oct 28, 2023
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good with the sdkKey-based channels!
I want to consider a sync-er shared for all synchronizations supporting different types of events. We can chat about the options.
jaeopt
approved these changes
Nov 14, 2023
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
LGTM - I want to discuss more about our options after we integrate datafile syncer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tickets