Skip to content

ci(codesign): upload build artifacts to s3 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2019
Merged

ci(codesign): upload build artifacts to s3 #127

merged 2 commits into from
Feb 15, 2019

Conversation

juancarlostong
Copy link
Contributor

@juancarlostong juancarlostong commented Jan 17, 2019 •
edited
Loading

Summary

  • Update OptimizelySDK.Travis.sln to produce Net40, Net35 builds
  • Generate NetStandard16 builds as well (in separate stage)
  • Upload dlls to s3
  • OASIS-4100

@juancarlostong juancarlostong changed the title upload to s3 [WIP] code sign testing Jan 17, 2019
@juancarlostong juancarlostong force-pushed the jctong/codesign branch 8 times, most recently from b84cb77 to a2934de Compare January 24, 2019 23:14
@juancarlostong juancarlostong changed the title [WIP] code sign testing code sign testing Jan 28, 2019
msohailhussain
msohailhussain reviewed Jan 28, 2019
View reviewed changes
msohailhussain
msohailhussain reviewed Jan 28, 2019
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just one suggestion to copy all dlls in a single command.

@juancarlostong juancarlostong changed the title code sign testing ci(codesign) Jan 28, 2019
@juancarlostong juancarlostong changed the title ci(codesign) ci(codesign): upload build artifacts to s3 Jan 28, 2019
msohailhussain
msohailhussain approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mikeproeng37
mikeproeng37 suggested changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I have a few comments and questions

@juancarlostong juancarlostong force-pushed the jctong/codesign branch 4 times, most recently from 86a5ac2 to 464fd71 Compare January 31, 2019 00:10
@juancarlostong juancarlostong force-pushed the jctong/codesign branch 7 times, most recently from 8939c64 to 5ef7516 Compare February 1, 2019 19:00
@juancarlostong
ci(codesign): upload build artifacts to s3
eb5ef0e 
Previously only OptimizelySDK.dll was being generated. Now generating:
OptimizelySDK.dll
OptimizelySDK.Net35.dll
OptimizelySDK.Net40.dll

NetStandard16 is a special case in that dotnet is used instead of mono.
Therefore it is relegated to its own stage where mono installation is
skipped and replaced with dotnet installation. (faster build)
@juancarlostong
ci(codesign): add strong naming
8720da2
mikeproeng37
mikeproeng37 approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 1840d1e into master Feb 15, 2019
@juancarlostong juancarlostong deleted the jctong/codesign branch April 1, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juancarlostong @mikeproeng37 @msohailhussain