-
Notifications
You must be signed in to change notification settings - Fork 20
chore(update version) #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
nitpick: you should also change it here: https://github.com/optimizely/csharp-sdk/pull/109/files#diff-bf67f3e7c1b4668fffb73733c1c3ebfaR22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
9007442
to
34ab9df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have a few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
updating version in other helper scripts
ba058bc
to
dd57630
Compare
Summary
remaining versioning changes to complete https://optimizely.atlassian.net/browse/OASIS-4088