Skip to content

chore(update version) #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 1, 2019
Merged

chore(update version) #136

merged 6 commits into from
Mar 1, 2019

Conversation

juancarlostong
Copy link
Contributor

@juancarlostong juancarlostong commented Feb 28, 2019

Summary

remaining versioning changes to complete https://optimizely.atlassian.net/browse/OASIS-4088

@juancarlostong
Copy link
Contributor Author

juancarlostong commented Feb 28, 2019

@mikeproeng37
Copy link
Contributor

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a few nits

Copy link
Contributor

@nchilada nchilada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@juancarlostong juancarlostong merged commit 17a0271 into master Mar 1, 2019
@juancarlostong juancarlostong deleted the jctong/versioning branch March 1, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants