Skip to content

ci(travis): add mdspell #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,24 @@ stages:
jobs:
include:
- stage: 'Lint markdown files'
language: ruby
rvm: 2.4.1
os: linux
language: generic
install: gem install awesome_bot
script:
- find . -type f -name '*.md' -exec awesome_bot {} \;
notifications:
email: false
- stage: 'Lint markdown files'
os: linux
language: generic
before_install: skip
install:
- npm i -g markdown-spellcheck
before_script:
- wget --quiet https://raw.githubusercontent.com/optimizely/mdspell-config/master/.spelling
script:
- mdspell -a -n -r --en-us '**/*.md'
after_success: skip
- &integrationtest
stage: 'Integration tests'
env: SDK=csharp SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH
Expand Down
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ January 23rd, 2020
- Call `GetOptimizelyConfig()` to get a snapshot copy of project configuration static data.
- It returns an `OptimizelyConfig` instance which includes a datafile revision number, all experiments, and feature flags mapped by their key values.
- Added caching for `GetOptimizelyConfig` - `OptimizelyConfig` object will be cached and reused for the lifetime of the datafile
- For details, refer to a documention page: https://docs.developers.optimizely.com/full-stack/docs/optimizelyconfig-csharp
- For details, refer to a documentation page: https://docs.developers.optimizely.com/full-stack/docs/optimizelyconfig-csharp

### Bug Fixes:
- Blocking timeout was not being assigned. When not providing any value, it was just logging not setting up periodinterval and blocking timeout value. [#202](https://github.com/optimizely/csharp-sdk/pull/202)
Expand All @@ -23,7 +23,7 @@ September 26th, 2019
- To configure event batching, set the `MaxEventBatchSize` and `MaxEventFlushInterval` properties in the `OptimizelyFactory` using `OptimizelyFactory.SetBatchSize(int batchSize)` and `OptimizelyFactory.SetFlushInterval(TimeSpan flushInterval)` and then creating using `OptimizelyFactory.NewDefaultInstance`.
- Event batching is enabled by default. `eventBatchSize` defaults to `10`. `eventFlushInterval` defaults to `30000` milliseconds.
- Updated the `Dispose` method representing the process of closing the instance. When `Dispose` is called, any events waiting to be sent as part of a batched event request will be immediately batched and sent to the event dispatcher.
- If any such requests were sent to the event dispatcher, `Stop` waits for provided `TimeoutInterval` before stoping, so that events get successfully dispatched.
- If any such requests were sent to the event dispatcher, `Stop` waits for provided `TimeoutInterval` before stopping, so that events get successfully dispatched.
- `OptimizelyFactory` now provides support of setting configuration variables from ***App.config***, User will now be able to provide configuration variables of `HttpConfigManager` and `BatchEventProcessor` in ***App.config***. Steps of usage are provided in [README.md](https://github.com/optimizely/csharp-sdk#using-appconfig-in-optimizelyfactory).

### Deprecated
Expand Down Expand Up @@ -119,7 +119,7 @@ October 26, 2018
* feat(api): Accepting all types for attributes values ([#102](https://github.com/optimizely/csharp-sdk/pull/102))

### Bug fixes
* fix(whitelistng): Removed logic from bucketing since it is checked in Decision Service. ([#98](https://github.com/optimizely/csharp-sdk/pull/98))
* fix(whitelisting): Removed logic from bucketing since it is checked in Decision Service. ([#98](https://github.com/optimizely/csharp-sdk/pull/98))
* fix(track): Send decisions for all experiments using an event when using track. ([#100](https://github.com/optimizely/csharp-sdk/pull/100))
* fix(datafile-parsing): Prevent newer versions datafile ([#101](https://github.com/optimizely/csharp-sdk/pull/101))
* fix(api): Only track attributes with valid attribute types. ([#103](https://github.com/optimizely/csharp-sdk/pull/103))
Expand Down
2 changes: 1 addition & 1 deletion OptimizelySDK.DemoApp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Using the instructions below, you can run the app locally and mimic bucketing we
* Metrics: "Overall revenue"
* Event Key: "add_to_cart".
("Create New Event...", "Add to Experiment")
5. Save and start your experment
5. Save and start your experiment
("Create Experiment", "Start Experiment")
6. In "Audiences" tab of your project's Optimizely dashboard, create
* 3 Audience attributes "user_id", "user_name", and "age".
Expand Down
4 changes: 2 additions & 2 deletions OptimizelySDK.DemoApp/Scripts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ the poppers.
Some of the key points are:

- Position elements keeping them in their original DOM context (doesn't mess with your DOM!);
- Allows to export the computed informations to integrate with React and other view libraries;
- Allows to export the computed information to integrate with React and other view libraries;
- Supports Shadow DOM elements;
- Completely customizable thanks to the modifiers based structure;

Expand Down Expand Up @@ -122,7 +122,7 @@ var anotherPopper = new Popper(
### Callbacks

Popper.js supports two kinds of callbacks, the `onCreate` callback is called after
the popper has been initalized. The `onUpdate` one is called on any subsequent update.
the popper has been initialized. The `onUpdate` one is called on any subsequent update.

```js
const reference = document.querySelector('.my-button');
Expand Down