Skip to content

adding SDK guides for readme.io for readme-sync #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 27, 2020
Merged

Conversation

fscelliott
Copy link
Contributor

@fscelliott fscelliott commented May 5, 2020

Summary

The "why", or other context.
docs-as-code approach

Test plan

Issues

no formal jira corresponds; see #devx-readme-sync slack channel

@fscelliott
Copy link
Contributor Author

@juancarlostong sorry, I didn't dig into travis, but is it likely this is failing for the same spell checker reason?

@juancarlostong
Copy link
Contributor

yes thats right, ill fix it in your branch and bring your branch up to date with master so you wont have problems merging. remember to git pull your local branch

@mikeproeng37
Copy link
Contributor

@fscelliott or @juancarlostong please update the PR summary and make sure to fill in that section.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok to merge after you address the comments below. I'd say as a follow-up right after, we should convert those readme codeblocks to use MD codeblocks with ```

@juancarlostong juancarlostong merged commit 1bfbd32 into master May 27, 2020
@juancarlostong juancarlostong deleted the docs-frances branch May 27, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants