-
Notifications
You must be signed in to change notification settings - Fork 20
fix: Change string.Format style to string interpolation #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
#if NET35 | ||
private Dictionary<string, Dictionary<string, string>> ForcedVariationMap; | ||
#else | ||
private System.Collections.Concurrent.ConcurrentDictionary<string, Dictionary<string, string>> ForcedVariationMap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ThreadSafe dictionary.
TODO: Add unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, are you able to profile and show some numbers along with where/how you ran it? Just curious
Sure, I will share results. |
@mikeng13 I tested it separately and don't see any major difference. For more than 150K+ requests it took 0.5 seconds for this log. |
Thanks |
Summary
Test plan