Skip to content

fix: When rollout has no rule, should return null #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 14, 2020
Merged

fix: When rollout has no rule, should return null #235

merged 4 commits into from
Jul 14, 2020

Conversation

msohailhussain
Copy link
Contributor

Summary

  • When there is no rollout rule, it should getVariationForFeatureRollout should return false.

Test plan

  • FSC and all Unit tests must pass.
  • Added one unit test.

@msohailhussain msohailhussain marked this pull request as ready for review July 13, 2020 21:52
@msohailhussain msohailhussain requested a review from a team as a code owner July 13, 2020 21:52
@msohailhussain msohailhussain changed the title rolloutrule should be non-zero. fix: When rollout has no rule, should return null Jul 13, 2020
@msohailhussain msohailhussain removed their assignment Jul 13, 2020
@msohailhussain msohailhussain removed their assignment Jul 13, 2020
msohailhussain
msohailhussain commented Jul 13, 2020
View reviewed changes
OptimizelySDK.Tests/EmptyRolloutRule.json Outdated
"accountId": "8272261422",
"events": [],
"revision": "2"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add EOL.

mikeproeng37
mikeproeng37 approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 0b4477d into master Jul 14, 2020
@mikeproeng37 mikeproeng37 deleted the sohail/rolloutfix branch July 14, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msohailhussain @mikeproeng37