Skip to content

fix: srcclr should be first in a job #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2020
Merged

fix: srcclr should be first in a job #238

merged 3 commits into from
Jul 29, 2020

Conversation

msohailhussain
Copy link
Contributor

@msohailhussain msohailhussain commented Jul 28, 2020 •
edited by aliabbasrizvi
Loading

Summary

  • Source clear should be first n stage
  • Added dotnet, otherwise source clear was unable to run it's job.

Test plan

Checked here, and it's working fine.
https://travis-ci.org/github/optimizely/csharp-sdk/jobs/712722775

@msohailhussain msohailhussain changed the title DRAFT --- Sohail/sourceclearfix fix: srcclr should be first in a job Jul 28, 2020
@msohailhussain msohailhussain marked this pull request as ready for review July 28, 2020 22:32
@msohailhussain msohailhussain requested a review from a team as a code owner July 28, 2020 22:32
@msohailhussain msohailhussain removed their assignment Jul 29, 2020
@aliabbasrizvi aliabbasrizvi merged commit 296e413 into master Jul 29, 2020
@aliabbasrizvi aliabbasrizvi deleted the sohail/sourceclearfix branch July 29, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msohailhussain @aliabbasrizvi