Skip to content

feat(decide): clone user-context before calling optimizely decide #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 19, 2021
Merged

feat(decide): clone user-context before calling optimizely decide #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b201124
Cloned OptimizelyUserContext to maintain the same state in case of an…
mnoman09 Jan 12, 2021
18889ae
updated header
mnoman09 Jan 12, 2021
5642d48
Updated testcases to compare object should not be equal but content s…
mnoman09 Jan 12, 2021
2358d1f
Renamed clone to copy and using GetAttributes in it directly
mnoman09 Jan 13, 2021
f6c15e9
Merge branch 'master' into mnoman/cloneUserContext
msohailhussain Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions OptimizelySDK.Tests/OptimizelyUserContextTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
*
* Copyright 2020, Optimizely and contributors
* Copyright 2020-2021, Optimizely and contributors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -181,7 +181,8 @@ public void TestDecide()
Assert.AreEqual(decision.Variables.ToDictionary(), variablesExpected.ToDictionary());
Assert.AreEqual(decision.RuleKey, "test_experiment_multivariate");
Assert.AreEqual(decision.FlagKey, flagKey);
Assert.AreEqual(decision.UserContext, user);
Assert.AreNotEqual(decision.UserContext, user);
Assert.IsTrue(TestData.CompareObjects(decision.UserContext, user));
Assert.AreEqual(decision.Reasons.Length, 0);
}

Expand Down Expand Up @@ -551,7 +552,8 @@ public void DecideExcludeVariablesDecideOptions()
Assert.AreEqual(decision.Variables.ToDictionary(), variablesExpected);
Assert.AreEqual(decision.RuleKey, "test_experiment_multivariate");
Assert.AreEqual(decision.FlagKey, flagKey);
Assert.AreEqual(decision.UserContext, user);
Assert.AreNotEqual(decision.UserContext, user);
Assert.IsTrue(TestData.CompareObjects(decision.UserContext, user));
Assert.True(decision.Reasons.IsNullOrEmpty());
}

Expand Down Expand Up @@ -580,7 +582,8 @@ public void DecideIncludeReasonsDecideOptions()
Assert.False(decision.Enabled);
Assert.AreEqual(decision.RuleKey, "test_experiment_multivariate");
Assert.AreEqual(decision.FlagKey, flagKey);
Assert.AreEqual(decision.UserContext, user);
Assert.AreNotEqual(decision.UserContext, user);
Assert.IsTrue(TestData.CompareObjects(decision.UserContext, user));
Assert.True(decision.Reasons.IsNullOrEmpty());

decision = user.Decide(flagKey, decideOptions);
Expand Down Expand Up @@ -611,7 +614,8 @@ public void TestDoNotSendEventDecide()
Assert.AreEqual(decision.Variables.ToDictionary(), variablesExpected.ToDictionary());
Assert.AreEqual(decision.RuleKey, "test_experiment_multivariate");
Assert.AreEqual(decision.FlagKey, flagKey);
Assert.AreEqual(decision.UserContext, user);
Assert.AreNotEqual(decision.UserContext, user);
Assert.IsTrue(TestData.CompareObjects(decision.UserContext, user));
}

[Test]
Expand All @@ -638,7 +642,8 @@ public void TestDefaultDecideOptions()
Assert.AreEqual(decision.Variables.ToDictionary(), variablesExpected.ToDictionary());
Assert.AreEqual(decision.RuleKey, "test_experiment_multivariate");
Assert.AreEqual(decision.FlagKey, flagKey);
Assert.AreEqual(decision.UserContext, user);
Assert.AreNotEqual(decision.UserContext, user);
Assert.IsTrue(TestData.CompareObjects(decision.UserContext, user));
}

[Test]
Expand Down
13 changes: 9 additions & 4 deletions OptimizelySDK/OptimizelyUserContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2020, Optimizely
* Copyright 2020-2021, Optimizely
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -46,6 +46,8 @@ public OptimizelyUserContext(Optimizely optimizely, string userId, UserAttribute
UserId = userId;
}

private OptimizelyUserContext Copy() => new OptimizelyUserContext(Optimizely, UserId, GetAttributes(), ErrorHandler, Logger);

/// <summary>
/// Returns Optimizely instance associated with the UserContext.
/// </summary>
Expand Down Expand Up @@ -123,7 +125,8 @@ public OptimizelyDecision Decide(string key)
public OptimizelyDecision Decide(string key,
OptimizelyDecideOption[] options)
{
return Optimizely.Decide(this, key, options);
var optimizelyUserContext = Copy();
return Optimizely.Decide(optimizelyUserContext, key, options);
}

/// <summary>
Expand All @@ -133,7 +136,8 @@ public OptimizelyDecision Decide(string key,
/// <returns>A dictionary of all decision results, mapped by flag keys.</returns>
public Dictionary<string, OptimizelyDecision> DecideForKeys(string[] keys, OptimizelyDecideOption[] options)
{
return Optimizely.DecideForKeys(this, keys, options);
var optimizelyUserContext = Copy();
return Optimizely.DecideForKeys(optimizelyUserContext, keys, options);
}

/// <summary>
Expand Down Expand Up @@ -162,7 +166,8 @@ public Dictionary<string, OptimizelyDecision> DecideAll()
/// <returns>All decision results mapped by flag keys.</returns>
public Dictionary<string, OptimizelyDecision> DecideAll(OptimizelyDecideOption[] options)
{
return Optimizely.DecideAll(this, options);
var optimizelyUserContext = Copy();
return Optimizely.DecideAll(optimizelyUserContext, options);
}

/// <summary>
Expand Down