Skip to content

chore: preparing 3.9.1 release #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2021
Merged

chore: preparing 3.9.1 release #268

merged 3 commits into from
Jul 16, 2021

Conversation

msohailhussain
Copy link
Contributor

Summary

prepare for release 3.9.1

Test plan

All FSC and unit tests must be passed.

@msohailhussain msohailhussain requested a review from jaeopt July 16, 2021 17:37
@msohailhussain msohailhussain removed their assignment Jul 16, 2021
@msohailhussain msohailhussain marked this pull request as ready for review July 16, 2021 17:38
@msohailhussain msohailhussain requested a review from a team as a code owner July 16, 2021 17:38
keppel2
keppel2 reviewed Jul 16, 2021
View reviewed changes
CHANGELOG.md Outdated
July 16th, 2021

### Bug Fixes:
- Duplicate experiment key issue with multiple feature flag. While trying to get variation from the variationkeyMap, it was unable to find because the latest experimentKey was overriding the previous one. [#267](https://github.com/optimizely/csharp-sdk/pull/267)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flags?

@keppel2 keppel2 self-requested a review July 16, 2021 17:52
jaeopt
jaeopt approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the typo flags

@jaeopt jaeopt merged commit e54f4c9 into master Jul 16, 2021
@jaeopt jaeopt deleted the mnoman/prepare-3.9.1-release branch July 16, 2021 18:59
msohailhussain added a commit that referenced this pull request Jul 16, 2021
@msohailhussain
chore: preparing 3.9.1 release (#268)
eb78722
msohailhussain added a commit that referenced this pull request Jul 16, 2021
@msohailhussain
Preparing v3.9.1 (#269)
8814b67 
* feat: Duplicate experiment key issue with multi feature flag (#267)

* chore: preparing 3.9.1 release (#268)

* dlls generation for v3.9.x branch

updating branch so proper dlls are generated for this release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@The-inside-man The-inside-man The-inside-man approved these changes

@keppel2 keppel2 keppel2 approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msohailhussain @The-inside-man @keppel2 @jaeopt @mnoman09