Added csharp yml and integeration test github action #298
Conversation
try shell bash explicitly.
using msbuild.
.github/workflows/csharp.yml
Outdated
| branches: [ master ] | ||
| pull_request: | ||
| branches: [ master ] | ||
| workflow_dispatch: |
There was a problem hiding this comment.
What's the need here?
.github/workflows/csharp.yml
Outdated
|
|
||
| unit_test: | ||
| runs-on: ubuntu-latest | ||
|
|
.github/workflows/csharp.yml
Outdated
|
|
||
| unit_test: | ||
| runs-on: ubuntu-latest | ||
|
|
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
checkout@v3? can we use the same version across all sdks.
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
checkout@v3? can we use the same version across all sdks.
| echo "deb https://download.mono-project.com/repo/ubuntu stable-bionic main" | sudo tee /etc/apt/sources.list.d/mono-official-stable.list | ||
| sudo apt update | ||
| sudo apt install mono-devel | ||
| xbuild /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=$(pwd)/keypair.snk /p:Configuration=Release ./OptimizelySDK.Travis.sln |
There was a problem hiding this comment.
what's the result with msbuild?
| echo "deb https://download.mono-project.com/repo/ubuntu stable-bionic main" | sudo tee /etc/apt/sources.list.d/mono-official-stable.list | ||
| sudo apt update | ||
| sudo apt install mono-devel | ||
| xbuild /p:SignAssembly=true /p:AssemblyOriginatorKeyFile=$(pwd)/keypair.snk /p:Configuration=Release ./OptimizelySDK.Travis.sln |
There was a problem hiding this comment.
what's the result with msbuild?
.github/workflows/csharp.yml
Outdated
| sudo find . -path './OptimizelySDK*bin/Release/OptimizelySDK*.dll' -not -regex '.*Tests.*' -print0 | while IFS= read -r -d '' file; do sn -R $file ./keypair.snk; done | ||
|
|
||
| netStandard16: | ||
| runs-on: windows-latest |
There was a problem hiding this comment.
fix a windows version, otherwise it will cause problem in future.
.github/workflows/csharp.yml
Outdated
| sudo find . -path './OptimizelySDK*bin/Release/OptimizelySDK*.dll' -not -regex '.*Tests.*' -print0 | while IFS= read -r -d '' file; do sn -R $file ./keypair.snk; done | ||
|
|
||
| netStandard16: | ||
| runs-on: windows-latest |
There was a problem hiding this comment.
fix a windows version, otherwise it will cause problem in future.
| @@ -0,0 +1,16 @@ | |||
| name: Source clear | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
can we put master only
There was a problem hiding this comment.
GitHub Actions only runs scheduled jobs on the default branch of your repository (usually master or main)
.github/workflows/csharp.yml
Outdated
| branches: [ master ] | ||
| pull_request: | ||
| branches: [ master ] | ||
| workflow_dispatch: |
There was a problem hiding this comment.
What's the need here?
Summary
NOTE:
Passed build link
Test plan
All tests should pass