Skip to content

Added linter for csharp #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 25, 2022
Merged

Added linter for csharp #300

merged 16 commits into from
May 25, 2022

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented May 23, 2022 •
edited
Loading

Summary

  • Added superLinter to verify markdown files and .cs files using editorConfig file
  • Removed markdown lint stage as it is no longer needed
  • Linter will not verify existing issues as VALIDATE_ALL_CODEBASE is set to false.
  • editorconfig file contains configuration for IDE and gives suggestions and warning related to linting to make sure user follows the rules.

Test plan

msohailhussain
msohailhussain reviewed May 23, 2022
View reviewed changes
.github/workflows/csharp.yml
uses: github/super-linter@v4
env:
VALIDATE_ALL_CODEBASE: false
DEFAULT_BRANCH: master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean it only checks for master branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes It will compare and check linting of only the files which were modified and compares with master.

@msohailhussain msohailhussain marked this pull request as ready for review May 25, 2022 20:56
@msohailhussain msohailhussain requested a review from a team as a code owner May 25, 2022 20:56
msohailhussain
msohailhussain approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool.

@msohailhussain msohailhussain merged commit d66c987 into master May 25, 2022
@msohailhussain msohailhussain deleted the mnoman/gitActionLinter branch May 25, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees

@mnoman09 mnoman09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @msohailhussain @NomanShoaib