Skip to content

ci: uploading artifacts on push #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 27, 2022
Merged

ci: uploading artifacts on push #308

merged 17 commits into from
Jul 27, 2022

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Jul 27, 2022 •
edited by mikechu-optimizely
Loading

Summary

  • Added steps to upload the build artifacts on s3

Issues

  • OASIS-8370

@mnoman09 mnoman09 changed the title testing uploading artifacts ci: uploading artifacts on push Jul 27, 2022
@mnoman09 mnoman09 marked this pull request as ready for review July 27, 2022 14:20
@mnoman09 mnoman09 requested a review from a team as a code owner July 27, 2022 14:20
mikechu-optimizely
mikechu-optimizely reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added some comments about the removals.

I'm glad to get the upload to S3 going.

@mikechu-optimizely
Copy link
Contributor

We could add OASIS-8370 to the description to satisify the "Jira ticket reference check / jira_ticket_reference_check" if that's helpful

@mikechu-optimizely
Copy link
Contributor

I'll leave the Approval to @msohailhussain

msohailhussain
msohailhussain approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain changed the title ci: uploading artifacts on push OASIS-8370 ci: uploading artifacts on push Jul 27, 2022
@mikechu-optimizely mikechu-optimizely changed the title OASIS-8370 ci: uploading artifacts on push ci: uploading artifacts on push Jul 27, 2022
@mikechu-optimizely mikechu-optimizely merged commit 88000ed into master Jul 27, 2022
@mikechu-optimizely mikechu-optimizely deleted the mnoman/gitActionArtifacts branch July 27, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely left review comments

@msohailhussain msohailhussain msohailhussain approved these changes

Assignees

@mnoman09 mnoman09

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnoman09 @mikechu-optimizely @msohailhussain