Skip to content

refac(context): Refactor to make execution context optional for components #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 3, 2019

Conversation

mikeproeng37
Copy link
Contributor

@mikeproeng37 mikeproeng37 commented Oct 2, 2019

Summary

  • Aims to simplify the construction of the top level components by removing the executionContext from the required path
  • Renames some of the option functions to the new paradigm where they are prepended with With
  • Important caveat to note is that now we have to explicitly call the Start methods of the PollingConfigManager and QueueingEventProcessor

Test

  • Unit

@mikeproeng37 mikeproeng37 force-pushed the mng/refactor-execution-ctx branch from 8120103 to 8e3a0bb Compare October 3, 2019 18:49
@mikeproeng37 mikeproeng37 removed the wip label Oct 3, 2019
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Start be part of the EventProcessor interface?

Copy link
Contributor

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you ran the example (end-to-end) and it's not hanging because of wrong ExeContext then it looks good.

@mikeproeng37 mikeproeng37 merged commit 9bc5b0b into master Oct 3, 2019
@mikeproeng37 mikeproeng37 deleted the mng/refactor-execution-ctx branch October 4, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants