Skip to content

Revert signature changes to PollingProjectConfigManager. #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2019

Conversation

mikecdavis
Copy link
Contributor

Summary

  • Reverts signature changes for PollingProjectConfigManager
  • Store sdkKey on the PollingProjectConfigManager

A recent PR #195 broke backwards compatibility and added potential internal discrepancies of the current SDK. This change ensures that the SDK key used to initialize the Config Manager is used consistently throughout its lifecycle.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikecdavis mikecdavis merged commit 973644b into master Dec 4, 2019
@mikecdavis mikecdavis deleted the mikecdavis/fix-polling-config-manager branch December 4, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants