Skip to content

feat: Add observability metrics for event queue #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 8, 2020
Merged

feat: Add observability metrics for event queue #223

merged 9 commits into from
Jan 8, 2020

Conversation

pawels-optimizely
Copy link
Contributor

@pawels-optimizely pawels-optimizely commented Jan 2, 2020 •
edited
Loading

Summary

  • Added generic metrics through metrics registry, supporting Counter with Add() method and Gauge with Set() method
  • Used these new defined metrics for event dispatcher

@pawels-optimizely pawels-optimizely requested a review from a team as a code owner January 2, 2020 21:44
@mikecdavis mikecdavis self-requested a review January 2, 2020 23:42
mikeproeng37
mikeproeng37 previously requested changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like this generic approach way better. I've added a few comments in there.

mikecdavis
mikecdavis reviewed Jan 3, 2020
View reviewed changes
@mikeproeng37 mikeproeng37 dismissed their stale review January 3, 2020 23:03

Won't be around next week

mikecdavis
mikecdavis suggested changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I have a few naming suggestion and would prefer we restore the test assertions, but overall it's looking spot on.

mikecdavis
mikecdavis approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@mikecdavis mikecdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@pawels-optimizely pawels-optimizely merged commit d1b332c into master Jan 8, 2020
@pawels-optimizely pawels-optimizely deleted the pawel/revised_metrics branch January 8, 2020 17:43
mjc1283
mjc1283 reviewed Jan 8, 2020
View reviewed changes
pkg/event/dispatcher.go
Comment on lines +77 to +79
sucessFlush metrics.Counter
failFlushCounter metrics.Counter
retryFlushCounter metrics.Counter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two of these fields have Counter in the field name, but one doesn't - seems weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 left review comments

@mikecdavis mikecdavis mikecdavis approved these changes

@mikeproeng37 mikeproeng37 mikeproeng37 left review comments

Assignees

@pawels-optimizely pawels-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pawels-optimizely @mjc1283 @mikeproeng37 @mikecdavis