Skip to content

feat(event-dispatcher): Exposing logx URL for agent. #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 12, 2020
Merged

feat(event-dispatcher): Exposing logx URL for agent. #268

merged 6 commits into from
Jun 12, 2020

Conversation

yasirfolio3
Copy link
Contributor

Summary

  • Made eventEndpoint public to be accessed by agent.

Test Plan

  • FSC should pass.

Issues

@msohailhussain msohailhussain changed the title feat(event-dispatcher): Exposing logx URL for agent. (WIP) feat(event-dispatcher): Exposing logx URL for agent. Jun 3, 2020
@msohailhussain msohailhussain marked this pull request as ready for review June 3, 2020 18:25
@msohailhussain msohailhussain requested a review from a team as a code owner June 3, 2020 18:25
@msohailhussain msohailhussain removed their assignment Jun 3, 2020
mikeproeng37
mikeproeng37 approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pawels-optimizely
pawels-optimizely suggested changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are introducing a way to modify this endpoint, I think it should be set on BatchEventProcessor, and createLogEvent() can take a second parameter with that endpoint.

@yasirfolio3 yasirfolio3 removed their assignment Jun 8, 2020
pawels-optimizely
pawels-optimizely approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@pawels-optimizely pawels-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeproeng37 mikeproeng37 merged commit ef17eaf into master Jun 12, 2020
@mikeproeng37 mikeproeng37 deleted the yasir/logx-export branch June 12, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

Assignees
No one assigned
Labels
🤖 8 hrs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yasirfolio3 @mikeproeng37 @pawels-optimizely @msohailhussain @optimizely-codereview-bot