feat: Semantic Versioning implementation #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawels-optimizely
requested review from
msohailhussain and
thomaszurkan-optimizely
mikecdavis
reviewed
Aug 19, 2020
Contributor
mikecdavis
left a comment
mikecdavis
left a comment
There was a problem hiding this comment.
Organizationally it would be cleaner to have all the matchers under the same file, semver.go. Then we can have a single semver_test.go file and parameterize all of the gt, lt, ge, le, etc. All of those tests are the same test with the same setup, just slightly different assertions that can be unified.
mikecdavis
reviewed
Aug 19, 2020
mikecdavis
reviewed
Aug 20, 2020
Co-authored-by: Mike Davis <[email protected]>
msohailhussain
approved these changes
Aug 20, 2020
Contributor
msohailhussain
left a comment
msohailhussain
left a comment
There was a problem hiding this comment.
lgtm. please address before merge.
thomaszurkan-optimizely
suggested changes
Aug 20, 2020
Contributor
thomaszurkan-optimizely
left a comment
thomaszurkan-optimizely
left a comment
There was a problem hiding this comment.
A couple of quick updates.
https://github.com/optimizely/swift-sdk/pull/352/files
Can you fix the evaluator and add a few tests for beta? Thanks!
thomaszurkan-optimizely
approved these changes
Aug 21, 2020
Contributor
thomaszurkan-optimizely
left a comment
thomaszurkan-optimizely
left a comment
There was a problem hiding this comment.
LGTM. I'm going to turn on go sdk semver for FSC and see if it passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary