Skip to content

Conversation

@pawels-optimizely
Copy link
Contributor

@pawels-optimizely pawels-optimizely commented Oct 13, 2020

Summary

  • corrected logic for rollout services: don't populate experiment when variation is null
  • that should be safe and won't break notification center since
if featureDecision.Source == FeatureTest {
		sourceInfo["experimentKey"] = featureDecision.Experiment.Key
		sourceInfo["variationKey"] = featureDecision.Variation.Key
	}

is the only logic accessing featureDecision.Experiment directly. And our change is happening on the rollout only

@pawels-optimizely pawels-optimizely merged commit 9880f21 into master Oct 14, 2020
@pawels-optimizely pawels-optimizely deleted the pawel/fix_rollout_services branch October 14, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants