refact(forced-decision): Support for decision context added. #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
approved these changes
Oct 25, 2021
| if variationKey, ok := f.forcedDecisions[forcedDecision{flagKey: flagKey, ruleKey: ruleKey}]; ok { | ||
| return variationKey | ||
| if forcedDecision, ok := f.forcedDecisions[context]; ok { | ||
| decision.Variation = forcedDecision.Variation |
There was a problem hiding this comment.
Can we return forcedDecision instead of copying? It'll be independent of extension.
| if f.forcedDecisions[decision] != "" { | ||
| f.forcedDecisions[decision] = "" | ||
| if f.forcedDecisions[context].Variation != "" { | ||
| f.forcedDecisions[context] = OptimizelyForcedDecision{} |
There was a problem hiding this comment.
wondering if this is better than remove the key.
There was a problem hiding this comment.
Directly modifying the variation throws this error cannot assign to struct field f.forcedDecisions[context].Variation in map. I have committed a change to avoid creating a new object here.
| if len(f.forcedDecisions) == 0 { | ||
| return "" | ||
| return decision |
There was a problem hiding this comment.
Wondering if this is idiomatic to return empty struct (instead of nil, or paired with err)
There was a problem hiding this comment.
Returning an error is the natural way to do it, will make the change in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary