Skip to content

OASIS-8551 fix(attribute-validation): Adds validation on user attributes to only allow primitive types. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2022
Merged

OASIS-8551 fix(attribute-validation): Adds validation on user attributes to only allow primitive types. #339

merged 2 commits into from
Aug 29, 2022

Conversation

yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Aug 23, 2022 •
edited by msohailhussain
Loading

Summary

  • Adds validation on user attributes to only allow primitive types.
  • Adds unit tests.

Test plan

All tests should pass

ISSUE

OASIS-8551

@yasirfolio3 yasirfolio3 requested a review from a team as a code owner August 23, 2022 06:17
Mat001
Mat001 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
The valid types are those that are supported by the data backend, make sure that is aligned.

jaeopt
jaeopt approved these changes Aug 25, 2022
View reviewed changes
Copy link

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

msohailhussain
msohailhussain reviewed Aug 29, 2022
View reviewed changes
pkg/event/factory.go
}

// check if attribute value is valid
func isValidAttribute(value interface{}) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be in switch case.

msohailhussain
msohailhussain approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain changed the title fix(attribute-validation): Adds validation on user attributes to only allow primitive types. OASIS-8551 fix(attribute-validation): Adds validation on user attributes to only allow primitive types. Aug 29, 2022
@msohailhussain msohailhussain merged commit 46be3df into master Aug 29, 2022
@msohailhussain msohailhussain deleted the yasir/fix-attribute-validation branch August 29, 2022 17:38
@Mat001 Mat001 mentioned this pull request Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt jaeopt approved these changes

+1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yasirfolio3 yasirfolio3

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yasirfolio3 @Mat001 @msohailhussain @jaeopt