Skip to content

fix(visitor-timestamp): Fixes issue with visitor timestamp . #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

fix(visitor-timestamp): Fixes issue with visitor timestamp . #345

merged 1 commit into from
Oct 3, 2022

Conversation

yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Sep 30, 2022 •
edited
Loading

Summary

  • Fixes issue with visitor where dispatch timestamp was used instead of userEvent creation timestamp.

Issues

  • FSSDK-8641

Tests

  • Unit and integration tests should pass.

@yasirfolio3 yasirfolio3 requested a review from a team as a code owner September 30, 2022 05:59
jaeopt
jaeopt approved these changes Sep 30, 2022
View reviewed changes
Copy link

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

msohailhussain
msohailhussain approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msohailhussain msohailhussain merged commit 4313a44 into master Oct 3, 2022
@msohailhussain msohailhussain deleted the yasir/timestamp-fix-8641 branch October 3, 2022 05:15
@mnoman09 mnoman09 mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

+1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yasirfolio3 yasirfolio3

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yasirfolio3 @msohailhussain @jaeopt