Skip to content

Conversation

pulak-opti
Copy link
Contributor

@pulak-opti pulak-opti commented May 12, 2023

Summary

  • Fix error log

Issues

@pulak-opti pulak-opti changed the title fix(utils): logging correct error message in HTTP requests [FSSDK-9155] fix(utils): logging correct error message in HTTP requests May 12, 2023
@pulak-opti pulak-opti marked this pull request as ready for review May 12, 2023 13:29
@pulak-opti pulak-opti requested a review from a team as a code owner May 12, 2023 13:29
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added some NITs

Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes suggested.

Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pulak-opti pulak-opti merged commit e74765c into master May 15, 2023
@pulak-opti pulak-opti deleted the pulak/requester-error-log branch May 15, 2023 10:07
pulak-opti added a commit that referenced this pull request Oct 3, 2023
…ts (#374)

* Fixed error being logged in HTTP requests

* Added test for logged errors

* Improve test error checking + comments

* Fix unnecessary re-cast in Error

* Update copyright dates in headers

* add review changes

* Update bad url example

---------

Co-authored-by: Sean Pfeifer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants