Skip to content

Conversation

pulak-opti
Copy link
Contributor

Summary

  • Fix goroutine leak for ticker

Issues

@pulak-opti pulak-opti requested a review from a team as a code owner May 12, 2023 15:52
@pulak-opti pulak-opti changed the title fix(ticker): stop all tickers to prevent goroutine leak [FSSDK-9155] fix(ticker): stop all tickers to prevent goroutine leak May 12, 2023
Copy link
Contributor

@yasirfolio3 yasirfolio3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 nit suggestion, LGTM.

@pulak-opti pulak-opti marked this pull request as draft May 12, 2023 16:56
@pulak-opti pulak-opti marked this pull request as ready for review May 15, 2023 12:14
@pulak-opti pulak-opti merged commit 7ffed83 into master May 15, 2023
@pulak-opti pulak-opti deleted the pulak/fix-ticker branch May 15, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants