-
Notifications
You must be signed in to change notification settings - Fork 19
[FSSDK-11461] Go - Add SDK Multi-Region Support for Data Hosting #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds multi-region support for data hosting in the Go SDK, enabling event dispatching to region-specific endpoints (US and EU). The implementation includes region configuration in datafiles and dynamic endpoint selection based on the region setting.
- Introduces region-aware event endpoint mapping with support for US and EU regions
- Updates event structures to include region information throughout the event pipeline
- Adds comprehensive test coverage for EU region functionality
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
pkg/event/processor.go | Replaces hardcoded endpoint with region-based endpoint mapping |
pkg/event/events.go | Adds region field to Context and Batch event structures |
pkg/event/factory.go | Implements region-based endpoint selection logic |
pkg/config/interface.go | Extends ProjectConfig interface with GetRegion method |
pkg/config/datafileprojectconfig/entities/entities.go | Adds region field to Datafile entity |
pkg/config/datafileprojectconfig/config.go | Implements region configuration with US default |
pkg/event/processor_test.go | Adds comprehensive EU region testing |
pkg/event/factory_test.go | Updates test config to include region support |
pkg/event/dispatcher_test.go | Updates tests to use new endpoint mapping |
Multiple mock files | Adds GetRegion method to mock implementations |
Comments suppressed due to low confidence (1)
pkg/event/processor_test.go:354
- This initialization appears unrelated to the multi-region support feature. Consider moving this to a separate commit or explaining its relevance to region support.
WithEventDispatcher(dispatcher))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Summary
Test plan
Issues