Skip to content

Conversation

esrakartalOpt
Copy link
Contributor

Summary

  • Add Multi-Region Support for Data Hosting

Test plan

  • Created and added new test cases

Issues

@esrakartalOpt esrakartalOpt requested a review from Copilot August 7, 2025 16:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds multi-region support for data hosting in the Go SDK, enabling event dispatching to region-specific endpoints (US and EU). The implementation includes region configuration in datafiles and dynamic endpoint selection based on the region setting.

  • Introduces region-aware event endpoint mapping with support for US and EU regions
  • Updates event structures to include region information throughout the event pipeline
  • Adds comprehensive test coverage for EU region functionality

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/event/processor.go Replaces hardcoded endpoint with region-based endpoint mapping
pkg/event/events.go Adds region field to Context and Batch event structures
pkg/event/factory.go Implements region-based endpoint selection logic
pkg/config/interface.go Extends ProjectConfig interface with GetRegion method
pkg/config/datafileprojectconfig/entities/entities.go Adds region field to Datafile entity
pkg/config/datafileprojectconfig/config.go Implements region configuration with US default
pkg/event/processor_test.go Adds comprehensive EU region testing
pkg/event/factory_test.go Updates test config to include region support
pkg/event/dispatcher_test.go Updates tests to use new endpoint mapping
Multiple mock files Adds GetRegion method to mock implementations
Comments suppressed due to low confidence (1)

pkg/event/processor_test.go:354

  • This initialization appears unrelated to the multi-region support feature. Consider moving this to a separate commit or explaining its relevance to region support.
		WithEventDispatcher(dispatcher))

@esrakartalOpt esrakartalOpt marked this pull request as ready for review August 7, 2025 16:45
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some comments

Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@esrakartalOpt esrakartalOpt merged commit afaf5d6 into master Aug 11, 2025
20 of 21 checks passed
@esrakartalOpt esrakartalOpt deleted the esra/FSSDK-11461_go_eu_data_hosting branch August 11, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants