[FSSDK-11874] Remove holdouts from master #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2.0 release - Revert all holdout-related changes from PR #415 - Remove Holdout structs, methods, and processing logic from: * pkg/entities/experiment.go * pkg/config/datafileprojectconfig/entities/entities.go * pkg/config/datafileprojectconfig/config.go * pkg/config/datafileprojectconfig/config_test.go * pkg/config/datafileprojectconfig/mappers/experiment_test.go - Holdout functionality preserved in disable-holdouts-feature-toggle branch - Maintain clean CMAB-only release per reviewer requirements - All tests pass, public API compatibility maintained
- Add Cache interface to pkg/odp/lru_cache.go - Maintains backward compatibility for existing code importing from pkg/odp - Fixes breaking change where users could no longer use odp.Cache - Per reviewer feedback to preserve old public interfaces
raju-opti
requested changes
Sep 30, 2025
- Move pkg/odp/lru_cache.go to pkg/odp/cache/lru_cache.go - Update package declaration from 'odp' to 'cache' - Update imports to use alias 'pkgCache' to avoid naming conflicts - Restores the original import path for users who import pkg/odp/cache - Addresses reviewer feedback about restoring old cache path structure
Remove trailing whitespace from comment line to fix linter error.
raju-opti
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant holdouts from master branch in order to only release cmab.
Holdouts are placed into a clean new branch for separation of concerns.
https://jira.sso.episerver.net/browse/FSSDK-11874