Skip to content

[FSSDK-11500] publish ua_parser as a separate bundle #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

raju-opti
Copy link
Contributor

Summary

Issues

  • [FSSDK-11500]

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR publishes ua_parser as a separate bundle by adding dedicated bundling functions for CommonJS and ESM in the rollup configuration and updating package.json export mappings.

  • New bundling functions (cjsBundleForUAParser and esmBundleForUAParser) are introduced in rollup.config.js.
  • package.json is updated to export the ua_parser bundle and adjust dependency declarations.
  • The ua_parser module file is lightly modified, likely for formatting consistency.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
rollup.config.js Added new bundling functions and integrated them into the bundles
package.json Updated exports and dependency configurations for ua_parser
lib/odp/ua_parser/ua_parser.ts Minor formatting cleanup

@coveralls
Copy link

coveralls commented May 8, 2025

Coverage Status

coverage: 80.749%. remained the same
when pulling f0c5eb5 on raju/ua-parser
into 02fad58 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants