Skip to content

fix(decision-service): Adds bucketing id in getVariationForRollout method. #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 14, 2019
Merged

fix(decision-service): Adds bucketing id in getVariationForRollout method. #200

merged 5 commits into from
Jan 14, 2019

Conversation

mfahadahmed
Copy link
Contributor

@mfahadahmed mfahadahmed commented Dec 14, 2018 •
edited
Loading

Summary

  • Adds getBucketingId call in getVariationForRollout method to bucket user with provided bucketing id.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 97.239% when pulling 046db6c on fahad/bucketing-id-fix into 599858b on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0005%) to 97.239% when pulling 046db6c on fahad/bucketing-id-fix into 599858b on master.

@coveralls
Copy link

coveralls commented Dec 14, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 97.279% when pulling ea1cbfe on fahad/bucketing-id-fix into cfea9ce on master.

@mfahadahmed
Copy link
Contributor Author

Closing this PR as Bucketing ID is not supported in the rollout yet.

@mfahadahmed mfahadahmed reopened this Dec 19, 2018
@aliabbasrizvi
Copy link
Contributor

@mfahadahmed @msohailhussain I see that this was closed with a comment and then re-opened. I do not recall if bucketing ID is supported for rollout, so may be this change is not needed and PR can be closed?

aliabbasrizvi
aliabbasrizvi suggested changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced offline with @mikeng13
Since this is a change to our bucketing, I'd like to see some unit tests which confirm that __buildBucketerParams is called with the output of _getBucketingId .

Setting to revise.

mikeproeng37
mikeproeng37 approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37
Copy link
Contributor

Ran the corresponding Compat tests: https://github.com/optimizely/fullstack-sdk-compatibility-suite/pull/187

Test run: https://travis-ci.com/optimizely/fullstack-sdk-compatibility-suite/builds/97281183

@mikeproeng37 mikeproeng37 merged commit 9812af8 into master Jan 14, 2019
@mikeproeng37 mikeproeng37 deleted the fahad/bucketing-id-fix branch January 14, 2019 21:12
oakbani pushed a commit that referenced this pull request Apr 17, 2019
@mfahadahmed @oakbani
fix(decision-service): Adds bucketing id in getVariationForRollout me…
d6c3276 
…thod. (#200)

(cherry picked from commit 9812af8)
@rashidsp rashidsp mentioned this pull request Apr 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfahadahmed @coveralls @aliabbasrizvi @mikeproeng37