Skip to content

ci(travis): fix skippped test #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

juancarlostong
Copy link
Contributor

@juancarlostong juancarlostong commented Feb 14, 2019

matrix: include: and jobs: include: cannot coexist in .travis.yml so the job in the matrix is converted into a stage and then added to the jobs: include:

@juancarlostong juancarlostong force-pushed the jctong/fix_test_skipped branch 2 times, most recently from 70bde11 to 3f1f8f3 Compare February 14, 2019 18:50
matrix: include: and jobs: include: cannot coexist so the stages are
merged together under one.
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing!

@juancarlostong juancarlostong merged commit a0cecd4 into master Feb 14, 2019
@juancarlostong juancarlostong deleted the jctong/fix_test_skipped branch February 14, 2019 19:22
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.582% when pulling ffc1eea on jctong/fix_test_skipped into aa11fdb on master.

jordangarcia pushed a commit that referenced this pull request Feb 14, 2019
matrix: include: and jobs: include: cannot coexist so the stages are
merged together under one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants