Skip to content

refactor (event processor): Remove transformers, interceptors, and callbacks from event processor #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2019

Conversation

mjc1283
Copy link
Contributor

@mjc1283 mjc1283 commented Aug 7, 2019

Summary

This PR removes transformers, interceptors, and callbacks from the event processor. These extensibility features are currently unused in optimizely-sdk.

Test plan

Updated unit tests. Deleted tests for removed functionality. Manually tested. All other existing unit tests should pass.

Issues

https://optimizely.atlassian.net/browse/OASIS-5151

@mjc1283 mjc1283 requested review from mikeproeng37 and a team August 7, 2019 18:33
@mjc1283 mjc1283 changed the title refactor (event processor): Remove plugin interfaces from event processor refactor (event processor): Remove transformers, interceptors, and callbacks from event processor Aug 7, 2019
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Aug 7, 2019

Coverage Status

Coverage remained the same at 97.597% when pulling 147e9ea on mcarroll/OASIS-5151 into db3ac55 on master.

@mjc1283 mjc1283 merged commit 81c5b03 into master Aug 8, 2019
@mjc1283 mjc1283 deleted the mcarroll/OASIS-5151 branch August 8, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants