Skip to content

fix: made React Native peer dependencies optional and prep for release 0.9.4 for js-sdk-datafile-manager and 0.9.5 for js-sdk-event-processor #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Feb 2, 2022

Summary

Made the following peer dependencies optional in datafile-manager and event-processor packages.
@react-native-community/async-storage
@react-native-community/netinfo

Test Plan

  • Manually tested thoroughly
  • All tests pass

@zashraf1985 zashraf1985 requested a review from a team as a code owner February 2, 2022 16:59
@zashraf1985 zashraf1985 removed their assignment Feb 2, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.184% when pulling c0d3a9f on zeeshan/peer-deps-optional into 1bc6919 on master.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zashraf1985 zashraf1985 merged commit 4b1bf98 into master Feb 2, 2022
@zashraf1985 zashraf1985 deleted the zeeshan/peer-deps-optional branch February 2, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants